spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erikerlandson <...@git.apache.org>
Subject [GitHub] spark pull request #21366: [SPARK-24248][K8S][WIP] Use the Kubernetes API to...
Date Thu, 24 May 2018 23:14:57 GMT
Github user erikerlandson commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21366#discussion_r190755750
  
    --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/DeterministicExecutorPodsEventQueue.scala
---
    @@ -0,0 +1,41 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.scheduler.cluster.k8s
    +
    +import io.fabric8.kubernetes.api.model.Pod
    +import scala.collection.mutable
    +
    +class DeterministicExecutorPodsEventQueue extends ExecutorPodsEventQueue {
    +
    +  private val eventBuffer = mutable.Buffer.empty[Pod]
    +  private val subscribers = mutable.Buffer.empty[(Seq[Pod]) => Unit]
    +
    +  override def addSubscriber
    +      (processBatchIntervalMillis: Long)
    +      (onNextBatch: (Seq[Pod]) => Unit): Unit = {
    +    subscribers += onNextBatch
    +  }
    +
    +  override def stopProcessingEvents(): Unit = {}
    +
    +  override def pushPodUpdate(updatedPod: Pod): Unit = eventBuffer += updatedPod
    --- End diff --
    
    So events are pods themselves, as opposed to some event structure on pods?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message