spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...
Date Thu, 24 May 2018 02:30:25 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21379#discussion_r190450621
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
    @@ -78,7 +79,12 @@ private[sql] object JDBCRelation extends Logging {
         // Overflow and silliness can happen if you subtract then divide.
         // Here we get a little roundoff, but that's (hopefully) OK.
         val stride: Long = upperBound / numPartitions - lowerBound / numPartitions
    -    val column = partitioning.column
    +    val column = if (jdbcOptions.quotePartitionColumnName) {
    +      val dialect = JdbcDialects.get(jdbcOptions.url)
    +      dialect.quoteIdentifier(partitioning.column)
    --- End diff --
    
    ok, I will


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message