spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions
Date Sat, 12 May 2018 02:21:26 GMT
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/21054
  
    There is not a single function that can’t be called by expr. It mainly adds
    some type safety.
    
    On Fri, May 11, 2018 at 7:18 PM Hyukjin Kwon <notifications@github.com>
    wrote:
    
    > *@HyukjinKwon* commented on this pull request.
    > ------------------------------
    >
    > In sql/core/src/main/scala/org/apache/spark/sql/functions.scala
    > <https://github.com/apache/spark/pull/21054#discussion_r187761743>:
    >
    > > @@ -775,6 +775,178 @@ object functions {
    >     */
    >    def var_pop(columnName: String): Column = var_pop(Column(columnName))
    >
    > +  /**
    > +   * Aggregate function: returns the number of non-null pairs.
    > +   *
    > +   * @group agg_funcs
    > +   * @since 2.4.0
    > +   */
    > +  def regr_count(y: Column, x: Column): Column = withAggregateFunction {
    >
    > @rxin <https://github.com/rxin>, how about splitting up this file by the
    > group or something, or deprecating all the functions that can be called via
    > expr for 3.0.0? To me, it looked a bit odd when some functions exist and
    > some did not. It was an actual use case and I had to check which function
    > exists or not every time.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/21054#discussion_r187761743>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AATvPMuMFZtp285MrttmJfITKM6WS0pcks5txkZ0gaJpZM4TSBOu>
    > .
    >



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message