spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #21193: [SPARK-24121][SQL] Add API for handling expressio...
Date Tue, 08 May 2018 09:36:56 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21193#discussion_r186669860
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
    @@ -119,7 +121,7 @@ abstract class Expression extends TreeNode[Expression] {
     
       private def reduceCodeSize(ctx: CodegenContext, eval: ExprCode): Unit = {
         // TODO: support whole stage codegen too
    -    if (eval.code.trim.length > 1024 && ctx.INPUT_ROW != null && ctx.currentVars
== null) {
    +    if (eval.code.toString.length > 1024 && ctx.INPUT_ROW != null &&
ctx.currentVars == null) {
    --- End diff --
    
    Can you add a method to `code` that produces the size directly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message