spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #21243: [SPARK-24182][yarn] Improve error message when cl...
Date Tue, 08 May 2018 07:33:02 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21243#discussion_r186639699
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
    @@ -346,7 +346,7 @@ private[spark] class ApplicationMaster(args: ApplicationMasterArguments)
extends
         synchronized {
           if (!finished) {
             val inShutdown = ShutdownHookManager.inShutdown()
    -        if (registered) {
    +        if (registered || !isClusterMode) {
    --- End diff --
    
    Why would we need to add non-cluster mode check here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message