spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #21193: [SPARK-24121][SQL] Add API for handling expressio...
Date Tue, 08 May 2018 05:03:55 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21193#discussion_r186616773
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
    @@ -114,19 +114,128 @@ object JavaCode {
       }
     }
     
    +/**
    + * A trait representing a block of java code.
    + */
    +trait Block extends JavaCode {
    +
    +  // The expressions to be evaluated inside this block.
    +  def exprValues: Seq[ExprValue]
    +
    +  // Returns java code string for this code block.
    +  override def toString: String = _marginChar match {
    +    case Some(c) => code.stripMargin(c).trim
    +    case _ => code.trim
    +  }
    +
    +  // The leading prefix that should be stripped from each line.
    +  // By default we strip blanks or control characters followed by '|' from the line.
    +  var _marginChar: Option[Char] = Some('|')
    +
    +  def stripMargin(c: Char): this.type = {
    +    _marginChar = Some(c)
    +    this
    +  }
    +
    +  def stripMargin: this.type = {
    +    _marginChar = Some('|')
    +    this
    +  }
    +
    +  // Concatenates this block with other block.
    +  def + (other: Block): Block
    +}
    +
    +object Block {
    +
    +  val CODE_BLOCK_BUFFER_LENGTH: Int = 512
    +
    +  implicit def blocksToBlock(blocks: Seq[Block]): Block = Blocks(blocks)
    +
    +  implicit class BlockHelper(val sc: StringContext) extends AnyVal {
    +    def code(args: Any*): Block = {
    +      sc.checkLengths(args)
    +      if (sc.parts.length == 0) {
    +        EmptyBlock
    +      } else {
    +        args.foreach {
    +          case _: ExprValue =>
    +          case _: Int | _: Long | _: Float | _: Double | _: String =>
    +          case _: Block =>
    +          case other => throw new IllegalArgumentException(
    +            s"Can not interpolate ${other.getClass.getName} into code block.")
    +        }
    +        CodeBlock(sc.parts, args)
    +      }
    +    }
    +  }
    +}
    +
    +/**
    + * A block of java code. Including a sequence of code parts and some inputs to this block.
    + * The actual java code is generated by embedding the inputs into the code parts.
    + */
    +case class CodeBlock(codeParts: Seq[String], blockInputs: Seq[Any]) extends Block {
    +  override def exprValues: Seq[ExprValue] = {
    --- End diff --
    
    `lazy val`? this might be expensive.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message