spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #21259: [SPARK-24112][SQL] Add `convertMetastoreTableProp...
Date Mon, 07 May 2018 21:36:12 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21259#discussion_r186558838
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
    @@ -189,10 +189,12 @@ case class RelationConversions(
       // Return true for Apache ORC and Hive ORC-related configuration names.
       // Note that Spark doesn't support configurations like `hive.merge.orcfile.stripe.level`.
       private def isOrcProperty(key: String) =
    -    key.startsWith("orc.") || key.contains(".orc.")
    +    conf.getConf(HiveUtils.CONVERT_METASTORE_TABLE_PROPERTY) &&
    +      (key.startsWith("orc.") || key.contains(".orc."))
     
       private def isParquetProperty(key: String) =
    -    key.startsWith("parquet.") || key.contains(".parquet.")
    +    conf.getConf(HiveUtils.CONVERT_METASTORE_TABLE_PROPERTY) &&
    +      key.startsWith("parquet.") || key.contains(".parquet.")
    --- End diff --
    
    Oh. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message