spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #21068: [SPARK-16630][YARN] Blacklist a node if executors...
Date Wed, 02 May 2018 19:53:42 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21068#discussion_r185619109
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/FailureTracker.scala
---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.yarn
    +
    +import scala.collection.mutable
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.util.{Clock, SystemClock}
    +
    +/**
    + * FailureTracker is responsible for tracking executor failures both for each host separately
    + * and for all host altogether.
    +*/
    +private[spark] class FailureTracker(
    +    sparkConf: SparkConf,
    +    var clock: Clock = new SystemClock) extends Logging {
    --- End diff --
    
    Yes, that would be nice. That's what `FsHistoryProvider` does for example (although it
uses two constructors instead of a default value - either is fine really).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message