From reviews-return-634322-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Apr 12 02:08:26 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 053E818064A for ; Thu, 12 Apr 2018 02:08:25 +0200 (CEST) Received: (qmail 72578 invoked by uid 500); 12 Apr 2018 00:08:25 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 72567 invoked by uid 99); 12 Apr 2018 00:08:24 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 00:08:24 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6F3A4E09E8; Thu, 12 Apr 2018 00:08:24 +0000 (UTC) From: tdas To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #20828: [SPARK-23687][SS] Add a memory source for continu... Content-Type: text/plain Message-Id: <20180412000824.6F3A4E09E8@git1-us-west.apache.org> Date: Thu, 12 Apr 2018 00:08:24 +0000 (UTC) Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20828#discussion_r180933380 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala --- @@ -53,32 +53,24 @@ class ContinuousSuiteBase extends StreamTest { // A continuous trigger that will only fire the initial time for the duration of a test. // This allows clean testing with manual epoch advancement. protected val longContinuousTrigger = Trigger.Continuous("1 hour") + + override protected implicit val defaultTrigger = Trigger.Continuous(100) + override protected val defaultUseV2Sink = true } class ContinuousSuite extends ContinuousSuiteBase { import testImplicits._ - test("basic rate source") { - val df = spark.readStream - .format("rate") - .option("numPartitions", "5") - .option("rowsPerSecond", "5") - .load() - .select('value) + test("basic") { + val input = MemoryStream[Int] --- End diff -- I think that's too much to hope for right now. We can do that later. For now, let's make everything explicitly ContinuousMemoryStream. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org