spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #21144: [SPARK-24043][SQL] Interpreted Predicate should i...
Date Tue, 24 Apr 2018 21:46:05 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21144#discussion_r183890298
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
    @@ -36,6 +36,14 @@ object InterpretedPredicate {
     
     case class InterpretedPredicate(expression: Expression) extends BasePredicate {
       override def eval(r: InternalRow): Boolean = expression.eval(r).asInstanceOf[Boolean]
    +
    +  override def initialize(partitionIndex: Int): Unit = {
    +    super.initialize(partitionIndex)
    +    expression.foreach {
    +      case n: Nondeterministic => n.initialize(partitionIndex)
    +      case _ =>
    +    }
    +  }
     }
    --- End diff --
    
    Nah this is good like it is.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message