spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From foxish <...@git.apache.org>
Subject [GitHub] spark pull request #21092: [SPARK-23984][K8S][WIP] Initial Python Bindings f...
Date Wed, 18 Apr 2018 18:22:52 GMT
Github user foxish commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21092#discussion_r182523365
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala
---
    @@ -29,9 +30,11 @@ private[spark] class KubernetesExecutorBuilder(
       def buildFromFeatures(
         kubernetesConf: KubernetesConf[KubernetesExecutorSpecificConf]): SparkPod = {
         val baseFeatures = Seq(provideBasicStep(kubernetesConf))
    -    val allFeatures = if (kubernetesConf.roleSecretNamesToMountPaths.nonEmpty) {
    -      baseFeatures ++ Seq(provideSecretsStep(kubernetesConf))
    -    } else baseFeatures
    +    val maybeRoleSecretNamesStep = if (kubernetesConf.roleSecretNamesToMountPaths.nonEmpty)
{
    +      Some(provideSecretsStep(kubernetesConf)) } else None
    +    val allFeatures: Seq[KubernetesFeatureConfigStep] =
    --- End diff --
    
    It does not need any changes/arg passing during executor pod construction?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message