spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...
Date Wed, 11 Apr 2018 12:33:08 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21026#discussion_r180736396
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
    @@ -0,0 +1,166 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.expressions.codegen
    +
    +import java.lang.{Boolean => JBool}
    +
    +import scala.language.{existentials, implicitConversions}
    +
    +import org.apache.spark.sql.types.{BooleanType, DataType}
    +
    +/**
    + * Trait representing an opaque fragments of java code.
    + */
    +trait JavaCode {
    +  def code: String
    +  override def toString: String = code
    +}
    +
    +/**
    + * Utility functions for creating [[JavaCode]] fragments.
    + */
    +object JavaCode {
    +  /**
    +   * Create a java literal.
    +   */
    +  def literal(v: String, dataType: DataType): LiteralValue = dataType match {
    +    case BooleanType if v == "true" => TrueLiteral
    +    case BooleanType if v == "false" => FalseLiteral
    +    case _ => new LiteralValue(v, CodeGenerator.javaClass(dataType))
    +  }
    +
    +  /**
    +   * Create a default literal. This is null for reference types, false for boolean types
and
    +   * -1 for other primitive types.
    +   */
    +  def defaultLiteral(dataType: DataType): LiteralValue = {
    +    new LiteralValue(
    +      CodeGenerator.defaultValue(dataType, typedNull = true),
    +      CodeGenerator.javaClass(dataType))
    +  }
    +
    +  /**
    +   * Create a local java variable.
    +   */
    +  def variable(name: String, dataType: DataType): VariableValue = {
    +    variable(name, CodeGenerator.javaClass(dataType))
    +  }
    +
    +  /**
    +   * Create a local java variable.
    +   */
    +  def variable(name: String, javaClass: Class[_]): VariableValue = {
    +    VariableValue(name, javaClass)
    +  }
    +
    +  /**
    +   * Create a local isNull variable.
    +   */
    +  def isNullVariable(name: String): VariableValue = variable(name, BooleanType)
    --- End diff --
    
    It is used to create is null variables. That it currently creates a boolean variable is
actually not that important. I just want to create a narrow waste for this specific case,
so we can swap out stuff later on.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message