spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #20560: [SPARK-23375][SQL] Eliminate unneeded Sort in Opt...
Date Wed, 11 Apr 2018 11:09:58 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20560#discussion_r180716049
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
    @@ -169,4 +169,6 @@ case class InMemoryRelation(
     
       override protected def otherCopyArgs: Seq[AnyRef] =
         Seq(_cachedColumnBuffers, sizeInBytesStats, statsOfPlanToCache)
    +
    +  override def outputOrdering: Seq[SortOrder] = child.outputOrdering
    --- End diff --
    
    in SparkPlan
    ```
    /** Specifies how data is ordered in each partition. */
    def outputOrdering: Seq[SortOrder] = Nil
    ```
    
    So we can't do this


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message