spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From henryr <...@git.apache.org>
Subject [GitHub] spark pull request #20560: [SPARK-23375][SQL] Eliminate unneeded Sort in Opt...
Date Wed, 11 Apr 2018 00:02:23 GMT
Github user henryr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20560#discussion_r179003707
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
    @@ -274,3 +279,7 @@ abstract class BinaryNode extends LogicalPlan {
     
       override final def children: Seq[LogicalPlan] = Seq(left, right)
     }
    +
    +abstract class KeepOrderUnaryNode extends UnaryNode {
    --- End diff --
    
    `OrderPreservingUnaryNode`? Or perhaps do you think this would be better modeled as a
mixin trait?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message