spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...
Date Tue, 10 Apr 2018 20:19:15 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21026#discussion_r180554710
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -331,7 +333,7 @@ class CodegenContext {
           case _: StructType | _: ArrayType | _: MapType => s"$value = $initCode.copy();"
           case _ => s"$value = $initCode;"
         }
    -    ExprCode(code, FalseLiteral, GlobalValue(value, javaType(dataType)))
    +    ExprCode.forNonNullValue(JavaCode.global(value, dataType))
    --- End diff --
    
    oops


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message