spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gengliangwang <...@git.apache.org>
Subject [GitHub] spark issue #21029: [WIP][SPARK-23952] remove type parameter in DataReaderFa...
Date Tue, 10 Apr 2018 16:37:44 GMT
Github user gengliangwang commented on the issue:

    https://github.com/apache/spark/pull/21029
  
    +1
    From the PR #20933, we can see that there is a lot of common code between `DataReaderFactory[ColumnarBatch]`
and `DataReaderFactory[UnsafeRow]`, if we use the current method factory pattern.
    This change makes data source implementation easier, and we don't need to do runtime type
cast.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message