spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From edwinalu <...@git.apache.org>
Subject [GitHub] spark pull request #20940: [SPARK-23429][CORE] Add executor memory metrics t...
Date Mon, 09 Apr 2018 18:04:13 GMT
Github user edwinalu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20940#discussion_r180180795
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -772,6 +772,12 @@ private[spark] class Executor(
         val accumUpdates = new ArrayBuffer[(Long, Seq[AccumulatorV2[_, _]])]()
         val curGCTime = computeTotalGcTime()
     
    +    // get executor level memory metrics
    +    val executorUpdates = new ExecutorMetrics(System.currentTimeMillis(),
    +      ManagementFactory.getMemoryMXBean.getHeapMemoryUsage().getUsed(),
    --- End diff --
    
    We could add ManagementFactory.getMemoryMXBean.getNonHeapMemoryUsage().getUsed(), for
total non-heap memory used by the JVM.
    
    For direct and memory mapped usage, would collecting these be similar to https://gist.github.com/t3rmin4t0r/1a753ccdcfa8d111f07c
? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message