spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark issue #21000: [SPARK-23892][Test] Improve converge and fix lint error ...
Date Sat, 07 Apr 2018 14:15:53 GMT
Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/21000
  
    Or, is it better to change from 
    ```
    assertTrue(s1.startsWith(s1));
    assertTrue(s1.endsWith(s1));
    ```
    to
    ```
    assertTrue(s1.startsWith(s1));
    assertTrue(s1.endsWith(s1));
    assertTrue(s2.startsWith(s2));
    assertTrue(s2.endsWith(s2));
    assertTrue(s1.startsWith(s2));
    assertTrue(s1.endsWith(s2));
    assertTrue(s2.startsWith(s1));
    assertTrue(s2.endsWith(s1));
    ```
    ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message