spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From attilapiros <...@git.apache.org>
Subject [GitHub] spark pull request #20925: [SPARK-22941][core] Do not exit JVM when submit f...
Date Fri, 06 Apr 2018 18:29:20 GMT
Github user attilapiros commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20925#discussion_r179814761
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -289,27 +288,26 @@ private[deploy] class SparkSubmitArguments(args: Seq[String], env:
Map[String, S
         }
    --- End diff --
    
    This might be a good candidate to use your new error method instead of throwing the Exception
directly. It might happen there is client catching both Exception and SparkException and doing
very different things but I guess that is very unlikely case.   


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message