spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #20937: [SPARK-23094][SPARK-23723][SPARK-23724][SQL] Supp...
Date Thu, 05 Apr 2018 22:57:04 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20937#discussion_r179622965
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/CreateJacksonParser.scala
---
    @@ -39,11 +40,28 @@ private[sql] object CreateJacksonParser extends Serializable {
         jsonFactory.createParser(new InputStreamReader(bain, "UTF-8"))
       }
     
    -  def text(jsonFactory: JsonFactory, record: Text): JsonParser = {
    -    jsonFactory.createParser(record.getBytes, 0, record.getLength)
    +  def text(jsonFactory: JsonFactory, record: Text, encoding: Option[String]): JsonParser
= {
    --- End diff --
    
    ah, sure. I thought you missed (because they are hidden). will try to take another look
soon too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message