spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...
Date Thu, 05 Apr 2018 12:43:24 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20965#discussion_r179448598
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
    @@ -254,6 +256,80 @@ case class HashAggregateExec(
          """.stripMargin
       }
     
    +  // Extracts all the input variable references for a given `aggExpr`. This result will
be used
    +  // to split aggregation into small functions.
    +  private def getInputVariableReferences(
    --- End diff --
    
    hopefully this method will become easier after @viirya's PR gets merged. Anyway, this
seems to me quite a generic method: shall we move it to `CodeGenerator`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message