spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...
Date Tue, 03 Apr 2018 21:41:13 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19041#discussion_r178968393
  
    --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala ---
    @@ -0,0 +1,201 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark
    +
    +import java.util.concurrent.TimeUnit
    +
    +import scala.collection.JavaConverters._
    +import scala.concurrent.{ExecutionContext, Future, Promise}
    +import scala.util.Failure
    +
    +import com.google.common.cache.CacheBuilder
    +
    +import org.apache.spark.CacheRecoveryManager.{DoneRecovering, KillReason, Timeout}
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.internal.config.DYN_ALLOCATION_CACHE_RECOVERY_TIMEOUT
    +import org.apache.spark.rpc.RpcEndpointRef
    +import org.apache.spark.storage.BlockManagerId
    +import org.apache.spark.storage.BlockManagerMessages._
    +import org.apache.spark.util.ThreadUtils
    +
    +/**
    + * Responsible for asynchronously replicating all of an executor's cached blocks, and
then shutting
    + * it down.
    + */
    +private class CacheRecoveryManager(
    +    blockManagerMasterEndpoint: RpcEndpointRef,
    +    executorAllocationManager: ExecutorAllocationManager,
    +    conf: SparkConf)
    +  extends Logging {
    +
    +  private val forceKillAfterS = conf.get(DYN_ALLOCATION_CACHE_RECOVERY_TIMEOUT)
    +  private val threadPool = ThreadUtils.newDaemonCachedThreadPool("cache-recovery-manager-pool")
    +  private implicit val asyncExecutionContext = ExecutionContext.fromExecutorService(threadPool)
    +  private val scheduler =
    +    ThreadUtils.newDaemonSingleThreadScheduledExecutor("cache-recovery-shutdown-timers")
    +  private val recoveringExecutors = CacheBuilder.newBuilder()
    --- End diff --
    
    I find `recoveringExecutors` pretty confusing, I think its executors that are recovering
from some problem, but are going to be OK -- not executors that are about to die, which we
are recovering data from.  how about `drainingExecutors`?  (though I have a feeling this name
may have been discussed in earlier rounds of comments and this is what we settled on ... if
so, thats fine.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message