spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...
Date Sun, 01 Apr 2018 22:17:21 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20886#discussion_r178470268
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
    @@ -298,15 +302,28 @@ class SessionCatalog(
             makeQualifiedPath(tableDefinition.storage.locationUri.get)
           tableDefinition.copy(
             storage = tableDefinition.storage.copy(locationUri = Some(qualifiedTableLocation)),
    -        identifier = TableIdentifier(table, Some(db)))
    +        identifier = tableIdentifier)
         } else {
    -      tableDefinition.copy(identifier = TableIdentifier(table, Some(db)))
    +      tableDefinition.copy(identifier = tableIdentifier)
         }
     
         requireDbExists(db)
         externalCatalog.createTable(newTableDefinition, ignoreIfExists)
       }
     
    +  def validateTableLocation(table: CatalogTable, tableIdentifier: TableIdentifier): Unit
= {
    --- End diff --
    
    `CatalogTable ` already contains `TableIdentifier `. What is the reason you do not use
the one directly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message