From reviews-return-629799-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Mar 30 18:19:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 10811180647 for ; Fri, 30 Mar 2018 18:19:46 +0200 (CEST) Received: (qmail 40814 invoked by uid 500); 30 Mar 2018 16:19:46 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 40799 invoked by uid 99); 30 Mar 2018 16:19:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Mar 2018 16:19:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 089BADFF80; Fri, 30 Mar 2018 16:19:45 +0000 (UTC) From: gatorsmile To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #20914: [SPARK-23802][SQL] PropagateEmptyRelation can lea... Content-Type: text/plain Message-Id: <20180330161945.089BADFF80@git1-us-west.apache.org> Date: Fri, 30 Mar 2018 16:19:45 +0000 (UTC) Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20914#discussion_r178321109 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala --- @@ -107,7 +112,7 @@ class PropagateEmptyRelationSuite extends PlanTest { val query = testRelation1 .where(left) .join(testRelation2.where(right), joinType = jt, condition = Some('a.attr == 'b.attr)) - val optimized = Optimize.execute(query.analyze) + val optimized = Optimize.execute(query.analyze).analyze --- End diff -- We should fill the time zone in the optimizer rule --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org