From reviews-return-627675-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Mar 23 05:09:29 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8280D180676 for ; Fri, 23 Mar 2018 05:09:28 +0100 (CET) Received: (qmail 67555 invoked by uid 500); 23 Mar 2018 04:09:26 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 67539 invoked by uid 99); 23 Mar 2018 04:09:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2018 04:09:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 06763F675E; Fri, 23 Mar 2018 04:09:24 +0000 (UTC) From: squito To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ... Content-Type: text/plain Message-Id: <20180323040925.06763F675E@git1-us-west.apache.org> Date: Fri, 23 Mar 2018 04:09:24 +0000 (UTC) Github user squito commented on the issue: https://github.com/apache/spark/pull/20888 hmm you're right, I was looking at a different branch in my editor and didn't pay attention that it was reset in the code I linked to on master, oops. I still dont' understand your proposed solution, though -- how is checking `stageToKill != -1` better than checking `stageToKill > 0` in this case? --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org