From reviews-return-625372-archive-asf-public=cust-asf.ponee.io@spark.apache.org  Fri Mar 16 10:09:17 2018
Return-Path: <reviews-return-625372-archive-asf-public=cust-asf.ponee.io@spark.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 37E6F180608
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 16 Mar 2018 10:09:17 +0100 (CET)
Received: (qmail 33961 invoked by uid 500); 16 Mar 2018 09:09:16 -0000
Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@spark.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@spark.apache.org>
List-Post: <mailto:reviews@spark.apache.org>
List-Id: <reviews.spark.apache.org>
Delivered-To: mailing list reviews@spark.apache.org
Received: (qmail 33940 invoked by uid 99); 16 Mar 2018 09:09:15 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2018 09:09:15 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 85EF2F1802; Fri, 16 Mar 2018 09:09:13 +0000 (UTC)
From: maropu <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-20831-spark@git.apache.org>
In-Reply-To: <git-pr-20831-spark@git.apache.org>
Subject: [GitHub] spark pull request #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange w...
Content-Type: text/plain
Message-Id: <20180316090914.85EF2F1802@git1-us-west.apache.org>
Date: Fri, 16 Mar 2018 09:09:13 +0000 (UTC)

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20831#discussion_r175030682
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala ---
    @@ -68,6 +69,15 @@ case class InMemoryRelation(
     
       override protected def innerChildren: Seq[SparkPlan] = Seq(child)
     
    +  override def doCanonicalize(): logical.LogicalPlan =
    +    copy(output = output.map(QueryPlan.normalizeExprId(_, child.output)),
    +      storageLevel = StorageLevel.NONE,
    +      child = child.canonicalized,
    +      tableName = None)(
    +      _cachedColumnBuffers,
    +      sizeInBytesStats,
    +      statsOfPlanToCache)
    --- End diff --
    
    aha, ok. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org