From reviews-return-623148-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Mar 8 13:59:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4333118064C for ; Thu, 8 Mar 2018 13:59:17 +0100 (CET) Received: (qmail 62641 invoked by uid 500); 8 Mar 2018 12:59:16 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 62626 invoked by uid 99); 8 Mar 2018 12:59:15 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Mar 2018 12:59:15 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 95FD4F4E26; Thu, 8 Mar 2018 12:59:15 +0000 (UTC) From: hvanhovell To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su... Content-Type: text/plain Message-Id: <20180308125915.95FD4F4E26@git1-us-west.apache.org> Date: Thu, 8 Mar 2018 12:59:15 +0000 (UTC) Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173150013 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -121,6 +121,19 @@ object ScalaReflection extends ScalaReflection { case _ => false } + def classForNativeTypeOf(dt: DataType): Class[_] = dt match { --- End diff -- Shouldn't this match `CodeGenerator.boxedType` in terms of functionality? See my previous comments, but I am also missing complex types (struct, map & array). --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org