spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark pull request #20942: [SPARK-15009][PYTHON][FOLLOWUP] Add default param...
Date Thu, 29 Mar 2018 23:38:43 GMT
GitHub user BryanCutler opened a pull request:

    https://github.com/apache/spark/pull/20942

    [SPARK-15009][PYTHON][FOLLOWUP] Add default param checks for CountVectorizerModel

    ## What changes were proposed in this pull request?
    
    Adding test for default params for `CountVectorizerModel` constructed from vocabulary.
 This required that the param `maxDF` be added, which was done in SPARK-23615.
    
    ## How was this patch tested?
    
    Added an explicit test for CountVectorizerModel in DefaultValuesTests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BryanCutler/spark pyspark-CountVectorizerModel-default-param-test-SPARK-15009

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20942.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20942
    
----
commit ecafd2bcc7661e7f635473aea84eed5fcab2f211
Author: Bryan Cutler <cutlerb@...>
Date:   2018-03-29T23:32:09Z

    add default param checks for CountVectorizerModel

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message