spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #20850: [SPARK-23713][SQL] Cleanup UnsafeWriter and Buffe...
Date Sat, 17 Mar 2018 20:16:54 GMT
GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/20850

    [SPARK-23713][SQL] Cleanup UnsafeWriter and BufferHolder classes

    ## What changes were proposed in this pull request?
    
    This PR implemented the following cleanups related to  `UnsafeWriter` class:
    - Remove code duplication between `UnsafeRowWriter` and `UnsafeArrayWriter`
    - Make `BufferHolder` class internal by delegating its accessor methods to `UnsafeWriter`
    - Replace `UnsafeRow.setTotalSize(...)` with `UnsafeRowWriter.setTotalSize()`
    
    ## How was this patch tested?
    
    Tested by existing UTs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-23713

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20850.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20850
    
----
commit 0379f7cbff5cf58abe5fb5c1af6a64cd17e578fd
Author: Kazuaki Ishizaki <ishizaki@...>
Date:   2018-03-17T20:10:20Z

    initial commit

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message