spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #20847: [SPARK-23644][CORE][UI] Use absolute path for RES...
Date Fri, 16 Mar 2018 11:40:57 GMT
GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/20847

    [SPARK-23644][CORE][UI] Use absolute path for REST call in SHS

    SHS is using a relative path for the REST API call to get the list of the application
is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue
if the path doesn't end with a "/".
    
    Therefore, we should use an absolute path for the REST call as it is done for all the
other resources.
    
    manual tests
    Before the change:
    ![screen shot 2018-03-10 at 4 22 02 pm](https://user-images.githubusercontent.com/8821783/37244190-8ccf9d40-2485-11e8-8fa9-345bc81472fc.png)
    
    After the change:
    ![screen shot 2018-03-10 at 4 36 34 pm 1](https://user-images.githubusercontent.com/8821783/37244201-a1922810-2485-11e8-8856-eeab2bf5e180.png)
    
    Author: Marco Gaido <marcogaido91@gmail.com>
    
    Closes #20794 from mgaido91/SPARK-23644.
    
    ## What changes were proposed in this pull request?
    
    (Please fill in changes proposed in this fix)
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual
tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-23644_2.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20847.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20847
    
----
commit f130a3603386acee670788d545a9d38969fcf39f
Author: Marco Gaido <marcogaido91@...>
Date:   2018-03-16T07:12:26Z

    [SPARK-23644][CORE][UI] Use absolute path for REST call in SHS
    
    SHS is using a relative path for the REST API call to get the list of the application
is a relative path call. In case of the SHS being consumed through a proxy, it can be an issue
if the path doesn't end with a "/".
    
    Therefore, we should use an absolute path for the REST call as it is done for all the
other resources.
    
    manual tests
    Before the change:
    ![screen shot 2018-03-10 at 4 22 02 pm](https://user-images.githubusercontent.com/8821783/37244190-8ccf9d40-2485-11e8-8fa9-345bc81472fc.png)
    
    After the change:
    ![screen shot 2018-03-10 at 4 36 34 pm 1](https://user-images.githubusercontent.com/8821783/37244201-a1922810-2485-11e8-8856-eeab2bf5e180.png)
    
    Author: Marco Gaido <marcogaido91@gmail.com>
    
    Closes #20794 from mgaido91/SPARK-23644.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message