spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kevinyu98 <...@git.apache.org>
Subject [GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...
Date Sun, 11 Mar 2018 07:03:09 GMT
GitHub user kevinyu98 opened a pull request:

    https://github.com/apache/spark/pull/20795

    [SPARK-23486]cache the function name from the catalog for lookupFunctions

    ## What changes were proposed in this pull request?
    
    This PR will cache the function name from spark and external catalog, it is used by lookupFunctions
in the analyzer, and it is cached for each query plan. The original problem is reported in
the [ spark-19737](https://issues.apache.org/jira/browse/SPARK-19737) 
    
    ## How was this patch tested?
    
    I did unit testing on local machine, it shows that the cache will be used if there multiple
same functions in the same query. But I am not sure how I can add a test case into spark,
can you advice? thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinyu98/spark spark-23486

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20795
    
----
commit 701100c11126d7437dc03ef20b484e84e2f9cb2a
Author: Kevin Yu <qyu@...>
Date:   2018-03-11T06:40:27Z

    cache the function name from the catalog for lookupFunction

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message