spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #20914: [SPARK-23802][SQL] PropagateEmptyRelation can lea...
Date Fri, 30 Mar 2018 16:19:45 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20914#discussion_r178321109
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala
---
    @@ -107,7 +112,7 @@ class PropagateEmptyRelationSuite extends PlanTest {
           val query = testRelation1
             .where(left)
             .join(testRelation2.where(right), joinType = jt, condition = Some('a.attr ==
'b.attr))
    -      val optimized = Optimize.execute(query.analyze)
    +      val optimized = Optimize.execute(query.analyze).analyze
    --- End diff --
    
    We should fill the time zone in the optimizer rule


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message