spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #20753: [SPARK-23582][SQL] StaticInvoke should support in...
Date Tue, 27 Mar 2018 12:56:57 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20753#discussion_r177413074
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
    @@ -188,8 +189,30 @@ case class StaticInvoke(
       override def nullable: Boolean = needNullCheck || returnNullable
       override def children: Seq[Expression] = arguments
     
    -  override def eval(input: InternalRow): Any =
    -    throw new UnsupportedOperationException("Only code-generated evaluation is supported.")
    +  override def eval(input: InternalRow): Any = {
    +    val args = arguments.map(e => e.eval(input).asInstanceOf[Object])
    +    val argClasses = ScalaReflection.expressionJavaClasses(arguments)
    +    val cls = if (staticObject.getName == objectName) {
    +      staticObject
    +    } else {
    +      Utils.classForName(objectName)
    +    }
    +    val method = cls.getDeclaredMethod(functionName, argClasses : _*)
    +    if (needNullCheck && args.exists(_ == null)) {
    +      // return null if one of arguments is null
    +      null
    +    } else {
    +      val ret = method.invoke(null, args: _*)
    +
    +      if (CodeGenerator.defaultValue(dataType) == "null") {
    --- End diff --
    
    This is a bit scary. Can you just use `ScalaReflection.typeBoxedJavaMapping`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message