spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rednaxelafx <...@git.apache.org>
Subject [GitHub] spark issue #20779: [SPARK-23598][SQL] Make methods in BufferedRowIterator p...
Date Sat, 24 Mar 2018 08:43:58 GMT
Github user rednaxelafx commented on the issue:

    https://github.com/apache/spark/pull/20779
  
    Sorry for the late comment. This PR itself is LGTM. I'd just like to make some side comments
on why this bug is happening.
    
    Janino uses a peculiar encoding of implementing bridge methods for extended accessibility
from an inner class to members of its enclosing class. Here we're actually hitting a bug in
Janino where it missed creating bridge methods on the enclosing class (`GeneratedClass...`)
for `protected` members that it inherited from a base class (`BufferedRowIterator`).
    I've seen this bug in Janino before, and I plan to fix it in Janino soon. Once it's fixed
in Janino, we can safely use `protected` members such as `append` and `stopEarly` in nested
classes within `GeneratedClass...` again. Would anybody be interested in switching these methods
back to `protected` once it's fixed in Janino and Spark bumps the Janino dependency to that
new version?
    
    Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message