spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to...
Date Fri, 23 Mar 2018 18:09:17 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19876#discussion_r176821060
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
    @@ -86,7 +88,80 @@ private[util] sealed trait BaseReadWrite {
     }
     
     /**
    - * Abstract class for utility classes that can save ML instances.
    + * Implemented by objects that provide ML exportability.
    + *
    + * A new instance of this class will be instantiated each time a save call is made.
    + *
    + * Must have a valid zero argument constructor which will be called to instantiate.
    + *
    + * @since 2.3.0
    --- End diff --
    
    Need to update since annotations to 2.4.0


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message