spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark pull request #20842: [SPARK-23162][PySpark][ML] Add r2adj into Python ...
Date Thu, 22 Mar 2018 23:56:11 GMT
Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20842#discussion_r176606317
  
    --- Diff: python/pyspark/ml/regression.py ---
    @@ -347,6 +347,20 @@ def r2(self):
             """
             return self._call_java("r2")
     
    +    @property
    +    @since("2.4.0")
    +    def r2adj(self):
    +        """
    +        Returns Adjusted R^2^, the adjusted coefficient of determination.
    +
    +        .. seealso:: `Wikipedia coefficient of determination \
    +        <https://en.wikipedia.org/wiki/Coefficient_of_determination>`
    --- End diff --
    
    use the same link from the scaladoc https://en.wikipedia.org/wiki/Coefficient_of_determination#Adjusted_R2
    
    It also doesn't generate properly, you need a trailing `_` I believe (also need to fix
`def r2` if you don't mind). 
    
    it should be:
    ```
    .. seealso:: `Wikipedia coefficient of determination \
    <http://en.wikipedia.org/wiki/Coefficient_of_determination#Adjusted_R2>`_
    ```
    
    If you are able to, building the docs to check these is a good idea


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message