spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #20579: [SPARK-23372][SQL] Writing empty struct in parque...
Date Wed, 21 Mar 2018 17:09:02 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20579#discussion_r176163585
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
    @@ -719,4 +720,27 @@ object DataSource extends Logging {
         }
         globPath
       }
    +
    +  /**
    +   * Called before writing into a FileFormat based data source to make sure the
    +   * supplied schema is not empty.
    +   * @param schema
    +   */
    +  private def hasEmptySchema(schema: StructType): Unit = {
    +    def hasEmptySchemaInternal(schema: StructType): Boolean = {
    --- End diff --
    
    they should be `verifySchema` and `hasEmptySchema`, depending on their return type.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message