spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request #20786: [SPARK-14681][ML] Provide label/impurity stats fo...
Date Wed, 21 Mar 2018 00:14:31 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20786#discussion_r175955388
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
    @@ -84,35 +86,73 @@ private[ml] object Node {
       /**
        * Create a new Node from the old Node format, recursively creating child nodes as
needed.
        */
    -  def fromOld(oldNode: OldNode, categoricalFeatures: Map[Int, Int]): Node = {
    +  def fromOld(oldNode: OldNode, categoricalFeatures: Map[Int, Int],
    --- End diff --
    
    Please fix scala style  (here and elsewhere)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message