spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points
Date Tue, 20 Mar 2018 16:35:49 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20327#discussion_r175836822
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
    @@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
       def bind(): Unit = {
         assert(serverInfo.isEmpty, s"Attempted to bind $className more than once!")
         try {
    -      val host = Option(conf.getenv("SPARK_LOCAL_IP")).getOrElse("0.0.0.0")
    +      val host = if (Utils.isClusterMode(conf)) {
    --- End diff --
    
    I'd rather not change it unless it's fixing a problem. I don't see a problem being fixed
here. Also, we should avoid adding more and more cluster-specific logic.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message