spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ueshin <...@git.apache.org>
Subject [GitHub] spark pull request #20788: [SPARK-23647][PYTHON][SQL] Adds more types for hi...
Date Fri, 16 Mar 2018 17:17:55 GMT
Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20788#discussion_r175156065
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -437,10 +437,12 @@ def hint(self, name, *parameters):
             if not isinstance(name, str):
                 raise TypeError("name should be provided as str, got {0}".format(type(name)))
     
    +        allowed_types = (basestring, list, float, int)
    --- End diff --
    
    If we allow `list`, should we check the types recursively?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message