spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #20788: [SPARK-23647][PYTHON][SQL] Adds more types for hi...
Date Fri, 16 Mar 2018 06:46:47 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20788#discussion_r175008195
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -437,10 +437,11 @@ def hint(self, name, *parameters):
             if not isinstance(name, str):
                 raise TypeError("name should be provided as str, got {0}".format(type(name)))
     
    +        allowed_types = (basestring, list, float, int)
    --- End diff --
    
    yap ok - https://github.com/DylanGuedes/spark/blob/f5de3b8fce22a2d0c55b86066471579c5720ec97/python/pyspark/sql/dataframe.py#L22
    
    no, this should be good


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message