spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #20817: [SPARK-23599][SQL] Add a UUID generator from Pseu...
Date Fri, 16 Mar 2018 04:29:52 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20817#discussion_r174995443
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RandomUUIDGenerator.scala
---
    @@ -0,0 +1,39 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.util
    +
    +import java.util.UUID
    +
    +import org.apache.commons.math3.random.MersenneTwister
    +
    +/**
    + * This class is used to generate a UUID from Pseudo-Random Numbers.
    + *
    + * For the algorithm, see RFC 4122: A Universally Unique IDentifier (UUID) URN Namespace,
    + * section 4.4 "Algorithms for Creating a UUID from Truly Random or Pseudo-Random Numbers".
    + */
    +case class RandomUUIDGenerator(randomSeed: Long) {
    +  private val random = new MersenneTwister(randomSeed)
    +
    +  def getNextUUID(): UUID = {
    --- End diff --
    
    Sounds good. I've added it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message