spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #20687: [SPARK-23500][SQL] Fix complex type simplificatio...
Date Wed, 14 Mar 2018 21:20:36 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20687#discussion_r174613887
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypes.scala
---
    @@ -22,54 +22,34 @@ import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
     import org.apache.spark.sql.catalyst.rules.Rule
     
     /**
    -* push down operations into [[CreateNamedStructLike]].
    -*/
    -object SimplifyCreateStructOps extends Rule[LogicalPlan] {
    -  override def apply(plan: LogicalPlan): LogicalPlan = {
    -    plan.transformExpressionsUp {
    -      // push down field extraction
    + * Simplify redundant [[CreateNamedStructLike]], [[CreateArray]] and [[CreateMap]] expressions.
    + */
    +object SimplifyExtractValueOps extends Rule[LogicalPlan] {
    +  override def apply(plan: LogicalPlan): LogicalPlan = plan transform { case p =>
    +    p.transformExpressionsUp {
    --- End diff --
    
    Oh, right. I missed to consider that kind of cases.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message