spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kevinyu98 <...@git.apache.org>
Subject [GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...
Date Mon, 12 Mar 2018 04:29:00 GMT
Github user kevinyu98 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20795#discussion_r173692751
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -1192,10 +1193,18 @@ class Analyzer(
        * @see https://issues.apache.org/jira/browse/SPARK-19737
        */
       object LookupFunctions extends Rule[LogicalPlan] {
    -    override def apply(plan: LogicalPlan): LogicalPlan = plan.transformAllExpressions
{
    -      case f: UnresolvedFunction if !catalog.functionExists(f.name) =>
    -        withPosition(f) {
    -          throw new NoSuchFunctionException(f.name.database.getOrElse("default"), f.name.funcName)
    +    override def apply(plan: LogicalPlan): LogicalPlan = {
    +      val catalogFunctionNameSet = new mutable.HashSet[FunctionIdentifier]()
    +        plan.transformAllExpressions {
    --- End diff --
    
    changed, thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message