spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...
Date Thu, 08 Mar 2018 12:59:15 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20757#discussion_r173150013
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
    @@ -121,6 +121,19 @@ object ScalaReflection extends ScalaReflection {
         case _ => false
       }
     
    +  def classForNativeTypeOf(dt: DataType): Class[_] = dt match {
    --- End diff --
    
    Shouldn't this match `CodeGenerator.boxedType` in terms of functionality? See my previous
comments, but I am also missing complex types (struct, map & array).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message