spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #20750: [SPARK-23581][SQL] Add interpreted unsafe project...
Date Thu, 08 Mar 2018 11:26:09 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20750#discussion_r173132540
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
    @@ -93,6 +93,26 @@ public void setNullAt(int ordinal) {
         Platform.putLong(holder.buffer, getFieldOffset(ordinal), 0L);
       }
     
    +  @Override
    +  public void setNullByte(int ordinal) {
    --- End diff --
    
    I see, but I am not sure about having only some of these methods here. I mean, in `UnsafeArrayData`
we have also `setNullDouble`, `setNullFloat`, etc. etc. It seems a bit weird to me that some
of them are set at the parent level and some other no. It's not a big deal but I'd prefer
for consistency to have all of them. What do you think? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message