spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #20735: [MINOR][YARN] Add disable yarn.nodemanager.vmem-c...
Date Wed, 07 Mar 2018 03:21:58 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20735#discussion_r172732010
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
    @@ -736,7 +736,8 @@ private object YarnAllocator {
       def memLimitExceededLogMessage(diagnostics: String, pattern: Pattern): String = {
         val matcher = pattern.matcher(diagnostics)
         val diag = if (matcher.find()) " " + matcher.group() + "." else ""
    -    ("Container killed by YARN for exceeding memory limits." + diag
    -      + " Consider boosting spark.yarn.executor.memoryOverhead.")
    +    s"Container killed by YARN for exceeding memory limits. $diag " +
    +      "Consider boosting spark.yarn.executor.memoryOverhead or " +
    +      "disable yarn.nodemanager.vmem-check-enabled because of YARN-4714."
    --- End diff --
    
    nit: "disable" -> "disabling"?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message