spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mccheah <...@git.apache.org>
Subject [GitHub] spark pull request #20697: [SPARK-23010][k8s] Initial checkin of k8s integra...
Date Tue, 06 Mar 2018 22:42:35 GMT
Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20697#discussion_r172685889
  
    --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/cloud/CloudTestBackend.scala
---
    @@ -0,0 +1,41 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.integrationtest.backend.cloud
    +
    +import io.fabric8.kubernetes.client.{ConfigBuilder, DefaultKubernetesClient}
    +
    +import org.apache.spark.deploy.k8s.integrationtest.Utils
    +import org.apache.spark.deploy.k8s.integrationtest.backend.IntegrationTestBackend
    +
    +private[spark] object CloudTestBackend extends IntegrationTestBackend {
    --- End diff --
    
    To make this PR smaller, can we start by only introducing the Minikube-backed tests, and
then introduce the cloud ones in a separate push? Think that will make it easier to review.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message