spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #20750: [SPARK-23581][SQL] Add interpreted unsafe project...
Date Tue, 06 Mar 2018 19:35:10 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20750#discussion_r172634434
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
    @@ -146,6 +145,18 @@ object UnsafeProjection {
         create(exprs.map(BindReferences.bindReference(_, inputSchema)))
       }
     
    +  /**
    +   * Returns an [[UnsafeProjection]] for given sequence of bound Expressions.
    +   */
    +  protected def createProjection(exprs: Seq[Expression]): UnsafeProjection
    --- End diff --
    
    seems no place is calling this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message