spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...
Date Tue, 06 Mar 2018 07:16:07 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20433#discussion_r172426790
  
    --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
---
    @@ -790,6 +796,16 @@ ASC: 'ASC';
     DESC: 'DESC';
     FOR: 'FOR';
     INTERVAL: 'INTERVAL';
    +YEAR: 'YEAR' | 'YEARS';
    +MONTH: 'MONTH' | 'MONTHS';
    +WEEK: 'WEEK' | 'WEEKS';
    +DAY: 'DAY' | 'DAYS';
    +HOUR: 'HOUR' | 'HOURS';
    +MINUTE: 'MINUTE' | 'MINUTES';
    +SECOND: 'SECOND' | 'SECONDS';
    +MILLISECOND: 'MILLISECOND' | 'MILLISECONDS';
    --- End diff --
    
    nvm, it sounds like we already support them. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message